lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] Commented: (LUCENE-1678) Deprecate Analyzer.tokenStream
Date Mon, 13 Jul 2009 12:01:15 GMT


Uwe Schindler commented on LUCENE-1678:

Your solution is also cool, to fix the last problems with the core token streams in LUCENE-1693:
If somebody overrides a deprecated method in one of the core tokenstreams (that are not final),
the method is never called, because the indexer uses incrementToken per default. The same
can be used to fix this problem in TokenStream, too.

I will prepare a patch for this (I am currently preparing a new patch with some tests and
the solution for the problems with number of attribute instances may not be equals number
of attributes).

> Deprecate Analyzer.tokenStream
> ------------------------------
>                 Key: LUCENE-1678
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>         Attachments: LUCENE-1678.patch
> The addition of reusableTokenStream to the core analyzers unfortunately broke back compat
of external subclasses:
> On upgrading, such subclasses would silently not be used anymore, since Lucene's indexing
invokes reusableTokenStream.
> I think we should should at least deprecate Analyzer.tokenStream, today, so that users
see deprecation warnings if their classes override this method.  But going forward when we
want to change the API of core classes that are extended, I think we have to  introduce entirely
new classes, to keep back compatibility.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message