lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] Commented: (LUCENE-1754) Get rid of NonMatchingScorer from BooleanScorer2
Date Mon, 27 Jul 2009 11:31:15 GMT


Uwe Schindler commented on LUCENE-1754:

I am a little bit confused about the JavaDocs of iterator():
/** Provides a {@link DocIdSetIterator} to access the set.
 * This may (but is not required to) return null if there
 * are no docs that match. */

Is it really allowed to return null instead of an empty iterator? If not, we should silently
remove this part of the docs (and hopefully do not break some filters written by someone).

> Get rid of NonMatchingScorer from BooleanScorer2
> ------------------------------------------------
>                 Key: LUCENE-1754
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Shai Erera
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>         Attachments: LUCENE-1754-2.patch, LUCENE-1754-2.patch, LUCENE-1754.patch, LUCENE-1754.patch,
LUCENE-1754.patch, LUCENE-1754.patch
> Over in LUCENE-1614 Mike has made a comment about removing NonMatchinScorer from BS2,
and return null in BooleanWeight.scorer(). I've checked and this can be easily done, so I'm
going to post a patch shortly. For reference:
> I've marked the issue as 2.9 just because it's small, and kind of related to all the
search enhancements done for 2.9.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message