lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (LUCENE-1644) Enable MultiTermQuery's constant score mode to also use BooleanQuery under the hood
Date Wed, 22 Jul 2009 20:39:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734301#action_12734301
] 

Uwe Schindler edited comment on LUCENE-1644 at 7/22/09 1:38 PM:
----------------------------------------------------------------

Hi Mike,

patch looks good. I was a little bit confused about the high term number cut off, but it is
using Math.max to limit it to the current BooleanQuery max clause count.

Some small things:

bq. OK I made getEnum protected again.

...but only in MultiTermQuery itsself. Everywhere else (even in the backwards compatibility
override test [JustCompile] it is public).

Also the current singletons are not really singletons, because queries that are unserialized
will contain instances that are not the "singleton" instances :) - and will therefore fail
to produce correct hashcode/equals tests. The problem behind: The singletons are serializable
but do not return itsself in readResolve() (not implemented). All singletons that are serializable
must implement readResolve and return the singleton instance (see Parameter base class or
the parser singletons in FieldCache).

The instance in the default Auto RewriteMethod is still modifiable. Is this correct? So one
could modify the defaults by setting properties in this instance. Is this correct?

      was (Author: thetaphi):
    Hi Mike,

patch looks good. I was a little bit confused about the high term number cut off, but it is
using Math.max to limit it to the current BooleanQuery max clause count.

Some small things:

bq. OK I made getEnum protected again.

...but only in MultiTermQuery itsself. Everywhere else (even in the backwards compatibility
override test [JustCompile] it is public).

Also the current singletons are not really singletons, because queries that are unserialized
will contain instances that are not the "singleton" instances :) - and will therefore fail
to produce correct hashcode/equals tests. The problem behind: The singletons are serializable
but do not return itsself in readResolve() (not implemented). All singletons that are serializable
must implement readResolve and return the singleton instance (see Parameter base class or
the parser singletons in FieldCache).
  
> Enable MultiTermQuery's constant score mode to also use BooleanQuery under the hood
> -----------------------------------------------------------------------------------
>
>                 Key: LUCENE-1644
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1644
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1644.patch, LUCENE-1644.patch, LUCENE-1644.patch
>
>
> When MultiTermQuery is used (via one of its subclasses, eg
> WildcardQuery, PrefixQuery, FuzzyQuery, etc.), you can ask it to use
> "constant score mode", which pre-builds a filter and then wraps that
> filter as a ConstantScoreQuery.
> If you don't set that, it instead builds a [potentially massive]
> BooleanQuery with one SHOULD clause per term.
> There are some limitations of this approach:
>   * The scores returned by the BooleanQuery are often quite
>     meaningless to the app, so, one should be able to use a
>     BooleanQuery yet get constant scores back.  (Though I vaguely
>     remember at least one example someone raised where the scores were
>     useful...).
>   * The resulting BooleanQuery can easily have too many clauses,
>     throwing an extremely confusing exception to newish users.
>   * It'd be better to have the freedom to pick "build filter up front"
>     vs "build massive BooleanQuery", when constant scoring is enabled,
>     because they have different performance tradeoffs.
>   * In constant score mode, an OpenBitSet is always used, yet for
>     sparse bit sets this does not give good performance.
> I think we could address these issues by giving BooleanQuery a
> constant score mode, then empower MultiTermQuery (when in constant
> score mode) to pick & choose whether to use BooleanQuery vs up-front
> filter, and finally empower MultiTermQuery to pick the best (sparse vs
> dense) bit set impl.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message