lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Earwin Burrfoot (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1748) getPayloadSpans on org.apache.lucene.search.spans.SpanQuery should be abstract
Date Sat, 18 Jul 2009 21:38:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732938#action_12732938
] 

Earwin Burrfoot commented on LUCENE-1748:
-----------------------------------------

bq. We should drop PayloadSpans and just add getPayload to Spans. This should be a compile
time break.
+1

> getPayloadSpans on org.apache.lucene.search.spans.SpanQuery should be abstract
> ------------------------------------------------------------------------------
>
>                 Key: LUCENE-1748
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1748
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Query/Scoring
>    Affects Versions: 2.4, 2.4.1
>         Environment: all
>            Reporter: Hugh Cayless
>             Fix For: 2.9, 3.0, 3.1
>
>
> I just spent a long time tracking down a bug resulting from upgrading to Lucene 2.4.1
on a project that implements some SpanQuerys of its own and was written against 2.3.  Since
the project's SpanQuerys didn't implement getPayloadSpans, the call to that method went to
SpanQuery.getPayloadSpans which returned null and caused a NullPointerException in the Lucene
code, far away from the actual source of the problem.  
> It would be much better for this kind of thing to show up at compile time, I think.
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message