lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1754) Get rid of NonMatchingScorer from BooleanScorer2
Date Mon, 20 Jul 2009 10:57:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733188#action_12733188
] 

Michael McCandless commented on LUCENE-1754:
--------------------------------------------

It seems like Weight.scorer() in general is allowed to return null to indicate "no docs will
match" (since some scorers do so, though others do not)?  Though that "right" wasn't spelled
out anywhere in the javadocs as best I can tell.  So... I don't think this is really a back-compat
break?

I think we should allow this, and document it clearly, going forward (in QueryWeight.scorer)?

I suppose we could fix the emulation of Weight on top of QueryWeight (QueryWeightWrapper)
to return NonMatchingScorer if it gets null back from QueryWeight.scorer?

> Get rid of NonMatchingScorer from BooleanScorer2
> ------------------------------------------------
>
>                 Key: LUCENE-1754
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1754
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Shai Erera
>            Priority: Minor
>             Fix For: 2.9
>
>
> Over in Lucene-1614 Mike has made a comment about removing NonMatchinScorer from BS2,
and return null in BooleanWeight.scorer(). I've checked and this can be easily done, so I'm
going to post a patch shortly. For reference: https://issues.apache.org/jira/browse/LUCENE-1614?focusedCommentId=12715064&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12715064.
> I've marked the issue as 2.9 just because it's small, and kind of related to all the
search enhancements done for 2.9.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message