lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Smith (JIRA)" <>
Subject [jira] Commented: (LUCENE-1754) Get rid of NonMatchingScorer from BooleanScorer2
Date Wed, 22 Jul 2009 15:31:14 GMT


Tim Smith commented on LUCENE-1754:

keeping null should be fine, as long as this is documented and all core query implementations
handle this behavior, and all searcher code handles the null return properly
at this point, NonMatchingScorer could be removed and null returned in its place (being package
private, no one writing applications can make any assumptions on a NonMatchingScorer being

however, this should also be documented for the rewrite() method (currently this looks to
always expect a non-null return value), also the searcher will throw null pointers if a null
query is passed to it 

> Get rid of NonMatchingScorer from BooleanScorer2
> ------------------------------------------------
>                 Key: LUCENE-1754
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Shai Erera
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>         Attachments: LUCENE-1754.patch
> Over in LUCENE-1614 Mike has made a comment about removing NonMatchinScorer from BS2,
and return null in BooleanWeight.scorer(). I've checked and this can be easily done, so I'm
going to post a patch shortly. For reference:
> I've marked the issue as 2.9 just because it's small, and kind of related to all the
search enhancements done for 2.9.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message