Return-Path: 
 <java-dev-return-35039-apmail-lucene-java-dev-archive=lucene.apache.org@lucene.apache.org>
Delivered-To: apmail-lucene-java-dev-archive@www.apache.org
Received: (qmail 9430 invoked from network); 19 Jun 2009 19:20:58 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 19 Jun 2009 19:20:58 -0000
Received: (qmail 58499 invoked by uid 500); 19 Jun 2009 19:21:08 -0000
Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org
Received: (qmail 58398 invoked by uid 500); 19 Jun 2009 19:21:08 -0000
Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:java-dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:java-dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:java-dev@lucene.apache.org>
List-Id: <java-dev.lucene.apache.org>
Reply-To: java-dev@lucene.apache.org
Delivered-To: mailing list java-dev@lucene.apache.org
Received: (qmail 58358 invoked by uid 99); 19 Jun 2009 19:21:08 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jun 2009 19:21:08 +0000
X-ASF-Spam-Status: No, hits=2.2 required=10.0
	tests=HTML_MESSAGE,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of serera@gmail.com designates
 74.125.78.24 as permitted sender)
Received: from [74.125.78.24] (HELO ey-out-2122.google.com) (74.125.78.24)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jun 2009 19:21:00 +0000
Received: by ey-out-2122.google.com with SMTP id 25so253568eya.53
        for <java-dev@lucene.apache.org>;
 Fri, 19 Jun 2009 12:20:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:date:message-id:subject
         :from:to:content-type;
        bh=JC/3SN32Edc8z2bRM3pYFjLzaPQVRpKv4ZX9k1zexZM=;
        b=djvTGGmCtsz7fxrO/HBwoffFDNPKe4MQebEM3XSRJJnvRpWtg5/iY6tx9b4q0Sac3d
         z8jzzbf86uuaRlwHlLp5BjMqcnzISlWqvhwjCi8CM71+EXrpH8NgaWN/IN7vsFNH+cuW
         BfSC/7NckQs3nCiEWuOghKh9eGO5ZTGfDKPVQ=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type;
        b=eB7b6eRzSjYIM4XALxsgDrbWZ8C6KAA4h2hAGCH0475iHq4lcPEl5bdR0cCDlE2tfU
         U4u+Qp+MqhHo0k5kSnvtUBQsgvJomy9QWU1x7AQ2+k5c3zyYx5bebXuHxzJta94M9Ekb
         lxAtZfKV23LEVkKce9Rj26Ty58hMS/6f20rkk=
MIME-Version: 1.0
Received: by 10.216.35.69 with SMTP id t47mr1210272wea.221.1245439238915;
 Fri,
	19 Jun 2009 12:20:38 -0700 (PDT)
Date: Fri, 19 Jun 2009 22:20:38 +0300
Message-ID: <786fde50906191220m7b385a2dt41cfbdbfa6b8ef2d@mail.gmail.com>
Subject: Shouldn't IndexWriter.commit(Map) accept Properties instead?
From: Shai Erera <serera@gmail.com>
To: java-dev@lucene.apache.org
Content-Type: multipart/alternative; boundary=0016367f9e546cc8a6046cb86b8f
X-Virus-Checked: Checked by ClamAV on apache.org

--0016367f9e546cc8a6046cb86b8f
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

It really assumes a String, String map ... Is it just because Properties is
synced?

If so, then when moving to 1.5 we should declare the Map with Map<String,
String> because currently if anyone will pass anything other than Strings,
the code will fail with a ClassCastException in
ChecksumIndexOutput.writeStringStringMap.

Shai

--0016367f9e546cc8a6046cb86b8f
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">It really assumes a String, String map ... Is it just beca=
use Properties is synced?<br><br>If so, then when moving to 1.5 we should d=
eclare the Map with Map&lt;String, String&gt; because currently if anyone w=
ill pass anything other than Strings, the code will fail with a ClassCastEx=
ception in ChecksumIndexOutput.writeStringStringMap.<br>
<br>Shai<br></div>

--0016367f9e546cc8a6046cb86b8f--