Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: pass (athena.apache.org: domain of serera@gmail.com designates
 209.85.219.227 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=MdHyjipiOhYTIbOuwQqlxxVZ2vCiXrTCq+bJCqflCFsKeYvmb7w0K2usJf3pi4fM1a
         UuI3m8XOIj5253QPIvMbzDkOpeLnrj57aAPmkbdAkg+u4Hgyn5GDWdHuH63DwqItEfFY
         mz0Kioj2C6VkKAoUcNS2/xSah7d8c7YDOVSfY=
MIME-Version: 1.0
In-Reply-To: <c68e39170906152015w74e4153emca55132b3f7999da@mail.gmail.com>
References: <c68e39170906151447u6d4b0a67xb99faaadcc7da7bd@mail.gmail.com>
	 <9ac0c6aa0906151535i5516cf05g80f3d83229b06fab@mail.gmail.com>
	 <786fde50906151953p4bcfa1daic983b8084297b5bd@mail.gmail.com>
	 <c68e39170906152015w74e4153emca55132b3f7999da@mail.gmail.com>
Date: Tue, 16 Jun 2009 06:31:54 +0300
Message-ID: <786fde50906152031p52c2bb57u2f532dc2aa99300d@mail.gmail.com>
Subject: Re: createWeight protected
From: Shai Erera <serera@gmail.com>
To: java-dev@lucene.apache.org, yonik@lucidimagination.com
Content-Type: multipart/alternative; boundary=0016e6ddab32edd9cf046c6ed078

--0016e6ddab32edd9cf046c6ed078
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

yes it is. just needs a volunteer to help me commit the patch.

On Tue, Jun 16, 2009 at 6:15 AM, Yonik Seeley <yonik@lucidimagination.com>wrote:

> On Mon, Jun 15, 2009 at 10:53 PM, Shai Erera<serera@gmail.com> wrote:
> > But note that Query has weight() and createWeight(), which I am still
> > confused about why we have two of them. Maybe I can consolidate them to
> one?
>
> createWeight() raw weight, and weight() is a top-level normalized weight.
> I don't think they should be consolidated, but good JavaDoc is needed.
>
> But the fact that "weight" is also a non-static public member is
> further evidence that createWeight() needs to be public (how else
> would one provide a different implementation?)
>
> > Anyway, I think this better be handled as part of LUCENE-1630, since the
> > Query and Weight classes are touched already in that are exactly.
>
> If it's going to make it into 2.9, that's fine.
>
> -Yonik
> http://www.lucidimagination.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>

--0016e6ddab32edd9cf046c6ed078
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">yes it is. just needs a volunteer to help me commit the pa=
tch.<br><br><div class=3D"gmail_quote">On Tue, Jun 16, 2009 at 6:15 AM, Yon=
ik Seeley <span dir=3D"ltr">&lt;<a href=3D"mailto:yonik@lucidimagination.co=
m">yonik@lucidimagination.com</a>&gt;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, =
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class=3D"im"=
>On Mon, Jun 15, 2009 at 10:53 PM, Shai Erera&lt;<a href=3D"mailto:serera@g=
mail.com">serera@gmail.com</a>&gt; wrote:<br>

&gt; But note that Query has weight() and createWeight(), which I am still<=
br>
&gt; confused about why we have two of them. Maybe I can consolidate them t=
o one?<br>
<br>
</div>createWeight() raw weight, and weight() is a top-level normalized wei=
ght.<br>
I don&#39;t think they should be consolidated, but good JavaDoc is needed.<=
br>
<br>
But the fact that &quot;weight&quot; is also a non-static public member is<=
br>
further evidence that createWeight() needs to be public (how else<br>
would one provide a different implementation?)<br>
<div class=3D"im"><br>
&gt; Anyway, I think this better be handled as part of LUCENE-1630, since t=
he<br>
&gt; Query and Weight classes are touched already in that are exactly.<br>
<br>
</div>If it&#39;s going to make it into 2.9, that&#39;s fine.<br>
<div><div></div><div class=3D"h5"><br>
-Yonik<br>
<a href=3D"http://www.lucidimagination.com" target=3D"_blank">http://www.lu=
cidimagination.com</a><br>
<br>
---------------------------------------------------------------------<br>
To unsubscribe, e-mail: <a href=3D"mailto:java-dev-unsubscribe@lucene.apach=
e.org">java-dev-unsubscribe@lucene.apache.org</a><br>
For additional commands, e-mail: <a href=3D"mailto:java-dev-help@lucene.apa=
che.org">java-dev-help@lucene.apache.org</a><br>
<br>
</div></div></blockquote></div><br></div>

--0016e6ddab32edd9cf046c6ed078--