Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 73021 invoked from network); 23 Jun 2009 22:07:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Jun 2009 22:07:46 -0000 Received: (qmail 91186 invoked by uid 500); 23 Jun 2009 22:07:37 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 91026 invoked by uid 500); 23 Jun 2009 22:07:37 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 90285 invoked by uid 99); 23 Jun 2009 22:01:32 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jun 2009 22:01:32 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jun 2009 22:01:29 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 79C99234C004 for ; Tue, 23 Jun 2009 15:01:08 -0700 (PDT) Message-ID: <277706544.1245794468487.JavaMail.jira@brutus> Date: Tue, 23 Jun 2009 15:01:08 -0700 (PDT) From: "Hoss Man (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-1712) Set default precisionStep for NumericField and NumericRangeFilter In-Reply-To: <88250643.1245704827891.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723324#action_12723324 ] Hoss Man commented on LUCENE-1712: ---------------------------------- {quote} By the way: It is also a good idea to use valSize (32 or 64) as precisionStep in the case that you do not want to do range queries on the field (and use it only for sorting). {quote} This screams out for additional (redundant) constants that are self documenting in their names... {code} int PRECISION_STEP_DEFAULT = 4; // i think? int PRECISION_STEP_SUGGESTED_INT_RANGEANDSORT = ...; // no idea what this should be int PRECISION_STEP_SUGGESTED_INT_SORTONLY = 32; // i think? int PRECISION_STEP_SUGGESTED_FLOAT_RANGEANDSORT = ...; // no idea what this should be int PRECISION_STEP_SUGGESTED_FLOAT_SORTONLY = 32; // i think? ... {code} > Set default precisionStep for NumericField and NumericRangeFilter > ----------------------------------------------------------------- > > Key: LUCENE-1712 > URL: https://issues.apache.org/jira/browse/LUCENE-1712 > Project: Lucene - Java > Issue Type: Improvement > Affects Versions: 2.9 > Reporter: Michael McCandless > Priority: Minor > Fix For: 2.9 > > > This is a spinoff from LUCENE-1701. > A user using Numeric* should not need to understand what's > "under the hood" in order to do their indexing & searching. > They should be able to simply: > {code} > doc.add(new NumericField("price", 15.50); > {code} > And have a decent default precisionStep selected for them. > Actually, if we add ctors to NumericField for each of the supported > types (so the above code works), we can set the default per-type. I > think we should do that? > 4 for int and 6 for long was proposed as good defaults. > The default need not be "perfect", as advanced users can always > optimize their precisionStep, and for users experiencing slow > RangeQuery performance, NumericRangeQuery with any of the defaults we > are discussing will be much faster. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org