lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Closed: (LUCENE-1453) When reopen returns a new IndexReader, both IndexReaders may now control the lifecycle of the underlying Directory which is managed by reference counting
Date Wed, 10 Jun 2009 12:28:07 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler closed LUCENE-1453.
---------------------------------

    Resolution: Fixed

Committed revision 783314. Thanks Mike! Next time I will also test-tag, sorry.

I will go through all other tests using FSDir.open() in trunk now and check, if there are
more cases, that rely on refcounting. They can be found easily, because they catch AlreadyClosedException.

> When reopen returns a new IndexReader, both IndexReaders may now control the lifecycle
of the underlying Directory which is managed by reference counting
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1453
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1453
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.4
>            Reporter: Mark Miller
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 2.9, 2.4.1
>
>         Attachments: Failing-testcase-LUCENE-1453.patch, LUCENE-1453-fix-TestIndexReader.patch,
LUCENE-1453-with-FSDir-open.patch, LUCENE-1453.patch, LUCENE-1453.patch, LUCENE-1453.patch,
LUCENE-1453.patch, LUCENE-1453.patch, LUCENE-1453.patch
>
>
> Rough summary. Basically, FSDirectory tracks references to FSDirectory and when IndexReader.reopen
shares a Directory with a created IndexReader and closeDirectory is true, FSDirectory's ref
management will see two decrements for one increment. You can end up getting an AlreadyClosed
exception on the Directory when the IndexReader is open.
> I have a test I'll put up. A solution seems fairly straightforward (at least in what
needs to be accomplished).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message