lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shai Erera <ser...@gmail.com>
Subject Re: createWeight protected
Date Tue, 16 Jun 2009 03:31:54 GMT
yes it is. just needs a volunteer to help me commit the patch.

On Tue, Jun 16, 2009 at 6:15 AM, Yonik Seeley <yonik@lucidimagination.com>wrote:

> On Mon, Jun 15, 2009 at 10:53 PM, Shai Erera<serera@gmail.com> wrote:
> > But note that Query has weight() and createWeight(), which I am still
> > confused about why we have two of them. Maybe I can consolidate them to
> one?
>
> createWeight() raw weight, and weight() is a top-level normalized weight.
> I don't think they should be consolidated, but good JavaDoc is needed.
>
> But the fact that "weight" is also a non-static public member is
> further evidence that createWeight() needs to be public (how else
> would one provide a different implementation?)
>
> > Anyway, I think this better be handled as part of LUCENE-1630, since the
> > Query and Weight classes are touched already in that are exactly.
>
> If it's going to make it into 2.9, that's fine.
>
> -Yonik
> http://www.lucidimagination.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>

Mime
View raw message