lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shai Erera <ser...@gmail.com>
Subject Re: createWeight protected
Date Tue, 16 Jun 2009 02:53:01 GMT
In LUCENE-1630 I've deprecated createWeight in favor of a new
createQueryWeight, also protected. So I can change the new one to public.

But note that Query has weight() and createWeight(), which I am still
confused about why we have two of them. Maybe I can consolidate them to one?

Anyway, I think this better be handled as part of LUCENE-1630, since the
Query and Weight classes are touched already in that are exactly.

Shai

On Tue, Jun 16, 2009 at 1:35 AM, Michael McCandless <
lucene@mikemccandless.com> wrote:

> +1
>
> Mike
>
> On Mon, Jun 15, 2009 at 5:47 PM, Yonik Seeley<yonik@lucidimagination.com>
> wrote:
> > I'm simply trying to create a query wrapper class to hold some
> > additional metadata, and delegate all operations to the wrapped query.
> > Something as simple as that.... can't do it because of java
> > permissions (outside of lucene).
> >
> >  protected Weight createWeight(Searcher searcher) throws IOException {
> >    return q.createWeight(searcher);  // we could call
> > super.createWeight() but not q.createWeight() !
> >  }
> >
> > createWeight seems somewhat expert-level, but not overly so, and it
> > does seem like it should be public instead of projected.
> > Thoughts?
> >
> > -Yonik
> > http://www.lucidimagination.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: java-dev-help@lucene.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>

Mime
View raw message