lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-1707) Don't use ensureOpen() excessively in IndexReader and IndexWriter
Date Wed, 24 Jun 2009 13:51:07 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shai Erera updated LUCENE-1707:
-------------------------------

    Attachment: LUCENE-1707.patch

Patch includes:
# remove all calls to ensureOpen in IndexReader and deprecated ensureOpen().
# remove most of the calls to ensureOpen in IndexWriter (those that happen at the beginning
of methods).
# added isOpen to both IndexReader and IndexWriter.
# deleted some test cases that checked this functionality.
# fixed tag (removed test cases)
# CHANGES

All tests pass, except for TestRussianStem under contrib/analyzers. But that does not seem
to be related to this patch, as it fails on a clean trunk checkout also. I think it has to
do w/ encoding, but I don't know if I'm the only one that experiences that.

> Don't use ensureOpen() excessively in IndexReader and IndexWriter
> -----------------------------------------------------------------
>
>                 Key: LUCENE-1707
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1707
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Shai Erera
>         Attachments: LUCENE-1707.patch
>
>
> A spin off from here: http://www.nabble.com/Excessive-use-of-ensureOpen()-td24127806.html.
> We should stop calling this method when it's not necessary for any internal Lucene code.
Currently, this code seems to hurt properly written apps, unnecessarily.
> Will post a patch soon

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message