lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-1680) Make prefixLength accessible to PrefixTermEnum subclasses
Date Wed, 10 Jun 2009 12:48:07 GMT


Michael McCandless commented on LUCENE-1680:

bq. Also, I think we can't suddenly change protected methods to private (that breaks back

I meant to say "can't suddenly change add 'final' to protected methods", but I see from your
new patch that you understood what I meant anyway :)

Patch looks good -- I'll commit shortly.  Thanks!

> Make prefixLength accessible to PrefixTermEnum subclasses
> ---------------------------------------------------------
>                 Key: LUCENE-1680
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 2.9
>            Reporter: Simon Willnauer
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>         Attachments: PrefixTermEnum.patch, PrefixTermEnum_2nd.patch
> PrefixTermEnum#difference() offers a way to influence scoring based on the difference
between the prefix Term and a term in the enumeration. To effectively use this facility the
length of the prefix should be accessible to subclasses. Currently the prefix term is private
to PrefixTermEnum. I added a getter for the prefix length and made PrefixTermEnum#endEnum(),
PrefixTermEnum#termCompare() final for consistency with other TermEnum subclasses.
> Patch is attached.
> Simon

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message