lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1680) Make prefixLength accessible to PrefixTermEnum subclasses
Date Wed, 10 Jun 2009 12:48:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718054#action_12718054
] 

Michael McCandless commented on LUCENE-1680:
--------------------------------------------

bq. Also, I think we can't suddenly change protected methods to private (that breaks back
compat).

I meant to say "can't suddenly change add 'final' to protected methods", but I see from your
new patch that you understood what I meant anyway :)

Patch looks good -- I'll commit shortly.  Thanks!

> Make prefixLength accessible to PrefixTermEnum subclasses
> ---------------------------------------------------------
>
>                 Key: LUCENE-1680
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1680
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 2.9
>            Reporter: Simon Willnauer
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: PrefixTermEnum.patch, PrefixTermEnum_2nd.patch
>
>
> PrefixTermEnum#difference() offers a way to influence scoring based on the difference
between the prefix Term and a term in the enumeration. To effectively use this facility the
length of the prefix should be accessible to subclasses. Currently the prefix term is private
to PrefixTermEnum. I added a getter for the prefix length and made PrefixTermEnum#endEnum(),
PrefixTermEnum#termCompare() final for consistency with other TermEnum subclasses.
> Patch is attached.
> Simon

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message