lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] Updated: (LUCENE-1714) WriteLineDocTask incorrectly normalizes fields
Date Tue, 23 Jun 2009 11:06:07 GMT


Shai Erera updated LUCENE-1714:

    Attachment: LUCENE-1714.patch

# Using a Matcher as a static final member, pre-compiled.
# Completed CHANGES
# Added a note to WriteLineDocTask about this task not being thread-safe. It never was, since
it writes to the output file in a non-synchronized way. Now with the addition of a static
Matcher member, it's even less thread-safe.

All benchmark tests pass.

> WriteLineDocTask incorrectly normalizes fields
> ----------------------------------------------
>                 Key: LUCENE-1714
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Shai Erera
>            Assignee: Michael McCandless
>             Fix For: 2.9
>         Attachments: LUCENE-1714.patch, LUCENE-1714.patch
> WriteLineDocTask normalizes the body, title and date fields by replacing any "\t" with
a space. However, if any one of them contains newlines, LineDocMaker will fail, since the
first line read will include some of the text, however the second line, which it now expects
to be a new document, will include other parts of the text.
> I don't know how we didn't hit it so far. Maybe the wikipedia text doesn't have such
lines, however when I ran over the TREC collection I hit a lot of those.
> I will attach a patch shortly.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message