lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1701) Add NumericField and NumericSortField, make plain text numeric parsers public in FieldCache, move trie parsers to FieldCache
Date Mon, 22 Jun 2009 10:32:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722551#action_12722551
] 

Michael McCandless commented on LUCENE-1701:
--------------------------------------------

The last patch looks great Uwe!  I think we're nearly done here:

  * I like how FieldComparator, and function/*FieldSource, are now
    simplified to longer have duplicated code for picking the default
    parser (and simply pass null instead).  Default selection is now
    single source.

  * Could you add the "<b>NOTE:</b> This API is experimental and might
    change in incompatible ways in the next release." caveat to the
    javadocs?

  * Can you change this:
{code}
if (parser == null) try {
  return getLongs(reader, field, DEFAULT_LONG_PARSER);
} catch (NumberFormatException ne) {
  return getLongs(reader, field, NUMERIC_UTILS_LONG_PARSER);      
}
{code}
to this:
{code}
if (parser == null) {
  try {
    return getLongs(reader, field, DEFAULT_LONG_PARSER);
  } catch (NumberFormatException ne) {
    return getLongs(reader, field, NUMERIC_UTILS_LONG_PARSER);      
  }
}
{code}
?
  * I think we can't actually deprecate NumberTools until we can call
    FieldCache.getShorts/getBytes on a NumericField?  Ie, people
    relying on short/byte (to consume much less memory in FieldCache)
    cannot switch to numeric, and so must continue to zero-pad if they
    need to use RangeQuery/Filter?

  * You need a CHANGES entry.


> Add NumericField and NumericSortField, make plain text numeric parsers public in FieldCache,
move trie parsers to FieldCache
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1701
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1701
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Index, Search
>    Affects Versions: 2.9
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 2.9
>
>         Attachments: LUCENE-1701-test-tag-special.patch, LUCENE-1701.patch, LUCENE-1701.patch,
LUCENE-1701.patch, LUCENE-1701.patch, LUCENE-1701.patch, NumericField.java
>
>
> In discussions about LUCENE-1673, Mike & me wanted to add a new NumericField to o.a.l.document
specific for easy indexing. An alternative would be to add a NumericUtils.newXxxField() factory,
that creates a preconfigured Field instance with norms and tf off, optionally a stored text
(LUCENE-1699) and the TokenStream already initialized. On the other hand NumericUtils.newXxxSortField
could be moved to NumericSortField.
> I and Yonik tend to use the factory for both, Mike tends to create the new classes.
> Also the parsers for string-formatted numerics are not public in FieldCache. As the new
SortField API (LUCENE-1478) makes it possible to support a parser in SortField instantiation,
it would be good to have the static parsers in FieldCache public available. SortField would
init its member variable to them (instead of NULL), so making code a lot easier (FieldComparator
has this ugly null checks when retrieving values from the cache).
> Moving the Trie parsers also as static instances into FieldCache would make the code
cleaner and we would be able to hide the "hack" StopFillCacheException by making it private
to FieldCache (currently its public because NumericUtils is in o.a.l.util).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message