lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1407) Refactor Searchable to not have RMI Remote dependency
Date Thu, 11 Jun 2009 12:43:08 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718428#action_12718428
] 

Shai Erera commented on LUCENE-1407:
------------------------------------

bq. Shai, I have looked at LUCENE-1630 but haven't seen any patch available

It's in the oven :)

bq. I feel removing Searchable in 2.9 is a heavy change and will most likely break back compat.


Back-compat is already broken in 2.9 due to the Collector work. So people who extend Searcher
will need to implement the new search(***, Collector) methods. As I understood it, Searcher
was really a replacement for Searchable, and I suspect it was left there not deprecated just
because of RMI.

We preferred to add new methods to Searcher as abstract, rather than to Searchable, b/c we
want to move away from interfaces. Therefore I don't think that delaying that work will do
any good - we'll have more methods to maintain on the interface as well.

But to be honest I don't know what's better. I can have Searcher extend the RMI class, but
that will leave RMI in core. Or I can have Searchable implement new methods, but that won't
take us in the ultimate direction we want - getting rid of interfaces.

> Refactor Searchable to not have RMI Remote dependency
> -----------------------------------------------------
>
>                 Key: LUCENE-1407
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1407
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Priority: Minor
>             Fix For: 2.9
>
>
> Per http://lucene.markmail.org/message/fu34tuomnqejchfj?q=RemoteSearchable
> We should refactor Searchable slightly so that it doesn't extend the java.rmi.Remote
marker interface.  I believe the same could be achieved by just marking the RemoteSearchable
and refactoring the RMI implementation out of core and into a contrib.
> If we do this, we should deprecate/denote it for 2.9 and then move it for 3.0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message