lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1687) Remove ExtendedFieldCache by rolling functionality into FieldCache
Date Sat, 20 Jun 2009 14:58:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722205#action_12722205
] 

Uwe Schindler commented on LUCENE-1687:
---------------------------------------

I implemented it now, when removing EFC completely, a lot of tests from backwards 2.4 fail,
especially TestSort and TestDateSort and FunctionQuery tests, because they:
- reference ExtendedFieldCache for parsers
- reference EXT_DEFAULT

There are a lot of projects that use this references, e.g. Compass and many more.

I left over a stub like noted above - and suddenly, all tests pass, only TestExtendedFieldCache,
which is obsolete (will be removed from Tag). Nobody is hurted by this stub (it is just an
empty declaration), all code is in FieldCache and FieldCacheImpl, as you suggested.

In 3.0 we remove the stub and voila!

> Remove ExtendedFieldCache by rolling functionality into FieldCache
> ------------------------------------------------------------------
>
>                 Key: LUCENE-1687
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1687
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 2.9
>
>
> It is silly that we have ExtendedFieldCache.  It is a workaround to our supposed back
compatibility problem.  This patch will merge the ExtendedFieldCache interface into FieldCache,
thereby breaking back compatibility, but creating a much simpler API for FieldCache.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message