lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1592) fix or deprecate TermsEnum.skipTo
Date Wed, 10 Jun 2009 22:27:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718237#action_12718237
] 

Uwe Schindler commented on LUCENE-1592:
---------------------------------------

I think deprecation is to do now (before 3.0), so why move this out?
I looked into the source code in trunk, this method is used nowhere, deprecating it should
be no problem:
{code}
@deprecated Use {@link IndexReader#terms(Term)} to
create a new TermEnum. This method is not performant.
{code}

> fix or deprecate TermsEnum.skipTo
> ---------------------------------
>
>                 Key: LUCENE-1592
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1592
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
>            Priority: Minor
>
> This method is a trap: it looks legitimate but it has hideously poor performance (simple
linear scan implemented in the TermsEnum base class since none of the concrete impls override
it with a more efficient implementation).
> The least we should do for 2.9 is deprecate the method with  a strong warning about its
performance.
> See here for background: http://www.lucidimagination.com/search/document/77dc4f8e893d3cf3/possible_terminfosreader_speedup
> And, here for historical context: 
> http://www.lucidimagination.com/search/document/88f1b95b404ebf16/remove_termenum_skipto_term_target

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message