lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Earwin Burrfoot (JIRA)" <>
Subject [jira] Commented: (LUCENE-1651) Make always return MSR to simplify (re-)opens.
Date Wed, 03 Jun 2009 11:44:07 GMT


Earwin Burrfoot commented on LUCENE-1651:

bq. Patch looks good Earwin, thanks!
I believe the readers can be cleaned up further, but I'm short on time and don't want to delay
it for another week or two, and then rebase it against updated trunk once again. Might as
well do that under a separate issue.

bq. I think we should now rename MultiSegmentReader to DirectoryIndexReader?
Maybe DirectoryReader instead of DirectoryIndexReader? But all three are in fact okay with
me, I really don't have any preference here.

> Make always return MSR to simplify (re-)opens.
> -----------------------------------------------------------------
>                 Key: LUCENE-1651
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Task
>    Affects Versions: 2.9
>            Reporter: Earwin Burrfoot
>            Assignee: Michael McCandless
>             Fix For: 2.9
>         Attachments: LUCENE-1651-tag.patch, LUCENE-1651.patch, LUCENE-1651.patch
> As per discussion in mailing list, I'm making always return
MSR, even for single-segment indexes.
> While theoretically valid in the past (if you make sure to keep your index constantly
optimized) this feature is made practically obsolete by per-segment collection.
> The patch somewhat de-hairies (re-)open logic for MSR/SR.
> SR no longer needs an ability to pose as toplevel directory-owning IR.
> All related logic is moved from DIR to MSR.
> DIR becomes almost empty, and copying two or three remaining fields over to MSR/SR, I
remove it.
> Lots of tests fail, as they rely on SR returned from, I fix by introducing
SR.getOnlySegmentReader static package-private method.
> Some previous bugs are uncovered, one is fixed in LUCENE-1645, another (partially fixed
in LUCENE-1648) is fixed in this patch. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message