lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (LUCENE-1453) When reopen returns a new IndexReader, both IndexReaders may now control the lifecycle of the underlying Directory which is managed by reference counting
Date Wed, 10 Jun 2009 12:08:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718041#action_12718041
] 

Uwe Schindler edited comment on LUCENE-1453 at 6/10/09 5:07 AM:
----------------------------------------------------------------

Thanks Mike,
it is from this fix. The test should normally also fail with trunk, but it doesn't because
we are using FSDir.open() in the trunk test. This is another test that relies on the refcounting
of FSDir.getDirectory.

The problem:
If you do IndexReader.open() on a invalid index and IndexReader.open fails with an Exception,
the Directory keeps open (because the wrapper has no chance to close it). I'll fix this and
also enable FSDir.getDirectory for this test in trunk.

      was (Author: thetaphi):
    Thanks Mike,
it is from this fix. The test should normally also fail with trunk, but it doesn't because
we are using FSDir.getDirectory() in the trunk test. This is another test that relies on the
refcounting of FSDir.getDirectory.

The problem:
If you do IndexReader.open() on a invalid index and IndexReader.open fails with an Exception,
the Directory keeps open (because the wrapper has no chance to close it). I'll fix this and
also enable FSDir.getDirectory for this test in trunk.
  
> When reopen returns a new IndexReader, both IndexReaders may now control the lifecycle
of the underlying Directory which is managed by reference counting
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1453
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1453
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.4
>            Reporter: Mark Miller
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 2.4.1, 2.9
>
>         Attachments: Failing-testcase-LUCENE-1453.patch, LUCENE-1453-fix-TestIndexReader.patch,
LUCENE-1453-with-FSDir-open.patch, LUCENE-1453.patch, LUCENE-1453.patch, LUCENE-1453.patch,
LUCENE-1453.patch, LUCENE-1453.patch, LUCENE-1453.patch
>
>
> Rough summary. Basically, FSDirectory tracks references to FSDirectory and when IndexReader.reopen
shares a Directory with a created IndexReader and closeDirectory is true, FSDirectory's ref
management will see two decrements for one increment. You can end up getting an AlreadyClosed
exception on the Directory when the IndexReader is open.
> I have a test I'll put up. A solution seems fairly straightforward (at least in what
needs to be accomplished).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message