lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1678) Deprecate Analyzer.tokenStream
Date Tue, 09 Jun 2009 21:46:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717831#action_12717831
] 

Mark Miller commented on LUCENE-1678:
-------------------------------------

>>Second this. Though I lost any hope for sane Lucene release/compat rules. 

Why? Have you seen anyone arguing for anything else?

If there are sane/smart ways to change our back compat policy, I think you have seen that
no one would object.

Its a complicated topic that has come up for discussion many times, but I don't think the
current policy is insane. And I have seen most people supporting whatever is best for Lucene.
But - see all of the posts on the topic. Its complicated. Nobody even really torpedoed anything,
its more that enough issues were raised and no one with a proper amount of authority felt
comfortable stepping up to the plate. Mike was gung ho for it for a while, and even he backed
off. Thats a great indication to me that the issue is not simple. Back compat currently is
not insane, but I think we all agree it should be loosened somehow in the future.

The way Lucene stuff generally goes, if someone like Grant or Mike really wanted to push changes,
the changes would happen. I think they both see that the effort involved in such a change
is not small though. Back compat is like our constitution. Its  a pain in the butt to change
in a way that everyone could get on board with. Even still, if someone really wanted to, they
could probably push through that. It seems we havn't gotten to such a point with anyone yet
though.

Giving up is really not the answer though - thats why the discussion has come and gone in
the past. The effort to get anything done grew (in terms of ideas as much as any implementation),
and one by one, the participants dropped out.

> Deprecate Analyzer.tokenStream
> ------------------------------
>
>                 Key: LUCENE-1678
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1678
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>
> The addition of reusableTokenStream to the core analyzers unfortunately broke back compat
of external subclasses:
>     http://www.nabble.com/Extending-StandardAnalyzer-considered-harmful-td23863822.html
> On upgrading, such subclasses would silently not be used anymore, since Lucene's indexing
invokes reusableTokenStream.
> I think we should should at least deprecate Analyzer.tokenStream, today, so that users
see deprecation warnings if their classes override this method.  But going forward when we
want to change the API of core classes that are extended, I think we have to  introduce entirely
new classes, to keep back compatibility.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message