lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1453) When reopen returns a new IndexReader, both IndexReaders may now control the lifecycle of the underlying Directory which is managed by reference counting
Date Tue, 09 Jun 2009 11:52:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717654#action_12717654
] 

Uwe Schindler commented on LUCENE-1453:
---------------------------------------

I forgot to mention:

bq. Oh, you mean there is an intermittent failure on the current trunk? (Ie, when using FSDir.getDirectory
under the hood).

Yes, for example, if you clone() and index that owns a directory. In this case the directory
was not cloned using the ugly hack currently in trunk (see patches before, which is also removed
again by my patch) and was then not correctly refcounted. During reopen(), sometimes DirectoryReader
uses clone() to create a new instance, when the readonly flag changed, but the index was not
modified. The testcase leads sometimes to exactly this behaviour and fails then.

My patch now also handles clone correctly, so it fixes all these problems by just factoring
out the deprecated Directory management to a FilterIndexReader. DirectoryReader just sees
the directory and will never try to close it.

> When reopen returns a new IndexReader, both IndexReaders may now control the lifecycle
of the underlying Directory which is managed by reference counting
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1453
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1453
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.4
>            Reporter: Mark Miller
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.4.1, 2.9
>
>         Attachments: Failing-testcase-LUCENE-1453.patch, LUCENE-1453-with-FSDir-open.patch,
LUCENE-1453.patch, LUCENE-1453.patch, LUCENE-1453.patch, LUCENE-1453.patch
>
>
> Rough summary. Basically, FSDirectory tracks references to FSDirectory and when IndexReader.reopen
shares a Directory with a created IndexReader and closeDirectory is true, FSDirectory's ref
management will see two decrements for one increment. You can end up getting an AlreadyClosed
exception on the Directory when the IndexReader is open.
> I have a test I'll put up. A solution seems fairly straightforward (at least in what
needs to be accomplished).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message