lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-1453) When reopen returns a new IndexReader, both IndexReaders may now control the lifecycle of the underlying Directory which is managed by reference counting
Date Mon, 08 Jun 2009 21:30:07 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-1453:
----------------------------------

    Attachment: LUCENE-1453.patch

This is the solution using the FilterIndexReader, all tests now pass (with refcounting deprectated
dirs as well as FSDir.open-dirs, see next Patch).
The solution consists of two parts:
- All closeDirectory stuff is removed from DirectoryIndexReader (even the ugly FSDir cloning)
and from ReadOnlyDirectoryIndexReader; the code is now simplier to understand. It is now on
the status for 3.0, no deprecated helper stuff anymore in these internal classes. So they
can be used in 3.0 without modifications.
- As the DirectoryIndexReader is not closing the directory anymore, the deprectated IndexReader.open
methods taking String/File would not work anymore correctly (because they miss to close the
dir on closing). To fix this easily, a deprectated private class extends FIlterIndexReader
was added, that wraps around the DirectoryIndexReader, when File/String opens are used. This
class keeps a refcounter that is incremented on reopen/clone and decremented on doClose().
The last doClose, closes the directory. In 3.0 this class can be removed easily with all File/String
open() methods. I could remove this class from IndexReader.java and put in a separate package-private
file, if you like.

I would like to have this in 2.9, to get rid of these ugly closeDirectory hacks! All tests
pass (I retried TestIndexReaderReopen about hundred times and no variant fails anymore). It
also works, when replacing the refcounting FSDir.getDirectory by FSDir.open() calls (see next
patch).

> When reopen returns a new IndexReader, both IndexReaders may now control the lifecycle
of the underlying Directory which is managed by reference counting
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1453
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1453
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.4
>            Reporter: Mark Miller
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.4.1, 2.9
>
>         Attachments: Failing-testcase-LUCENE-1453.patch, LUCENE-1453.patch, LUCENE-1453.patch,
LUCENE-1453.patch, LUCENE-1453.patch
>
>
> Rough summary. Basically, FSDirectory tracks references to FSDirectory and when IndexReader.reopen
shares a Directory with a created IndexReader and closeDirectory is true, FSDirectory's ref
management will see two decrements for one increment. You can end up getting an AlreadyClosed
exception on the Directory when the IndexReader is open.
> I have a test I'll put up. A solution seems fairly straightforward (at least in what
needs to be accomplished).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message