lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Assigned: (LUCENE-1504) SerialChainFilter should use DocSet API rather then deprecated BitSet API
Date Tue, 16 Jun 2009 09:37:07 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler reassigned LUCENE-1504:
-------------------------------------

    Assignee: Uwe Schindler

Hllo Ryan,
I will try to get this into 2.9, but before some comments on the current patch:
- You are still using BitSet in ISerialChainFilter. When we move this to core, I suggest to
use OpenBitSet here. Just change the method signature, it is unreleased code and so we can
change it easily. But you must then rewrite spatial to also use OpenBitSet (but it is just
a search'n'replace).
- ISerialChainFilter seems to be a strange name, I have never seen such in Lucene Core. Do
you mean "I"nterface with it (but its an abstract class). I would suggest to use SerialChainFilter
as it is, and for the chained filters itsself use ChainFilter.
- There are some of these autogenerated catch blocks in the code, please remove them and pass
the Exception through the method declaration. So bits() should throw IOException and so on
(this is one of the things, why I hate Eclipse..., searching through the internet you see
everywhere this code with these auto-generated blocks!)

> SerialChainFilter should use DocSet API rather then deprecated BitSet API
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-1504
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1504
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>            Reporter: Ryan McKinley
>            Assignee: Uwe Schindler
>             Fix For: 2.9
>
>         Attachments: LUCENE-1504.patch, LUCENE-1504.patch
>
>
> From erik's comments in LUCENE-1387
>     * Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated
stuff? We can refactor that after being committed I supposed, but not something we want to
leave like that.
> We should also look at moving SerialChainFilter out of the spatial contrib since it is
more generally useful then just spatial search.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message