lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] Created: (LUCENE-1686) Remove Unnecessary NULL check in FindSegmentsFile - cleanup
Date Fri, 12 Jun 2009 11:36:08 GMT
Remove Unnecessary NULL check in FindSegmentsFile - cleanup
-----------------------------------------------------------

                 Key: LUCENE-1686
                 URL: https://issues.apache.org/jira/browse/LUCENE-1686
             Project: Lucene - Java
          Issue Type: Improvement
            Reporter: Simon Willnauer
             Fix For: 2.9, 3.0
         Attachments: segments_info.patch

FindSegmentsFile accesses the member "directory" in line 579 while performing a null check
in 592. The null check is unnecessary as if directory is null line 579 would throw a NPE.
I removed the null check and made the member "directory" final. In addition I added a null
check in the constructor as If the value is null we should catch it asap. 



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message