lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (LUCENE-1614) Add next() and skipTo() variants to DocIdSetIterator that return the current doc, instead of boolean
Date Tue, 02 Jun 2009 08:57:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715428#action_12715428
] 

Uwe Schindler edited comment on LUCENE-1614 at 6/2/09 1:55 AM:
---------------------------------------------------------------

bq. I kept nextDoc() as is, i.e., calling doc() instead of docID(), since that's required
for back-compat.

But doc() is also deprecated, why should they have implemented it? This makes no sense for
me. Non-deprecated-code should always call non-deprectaed methods, so docID().

EDIT: Ah sorry, you are right. new iterators would override this method and not call doc()
and next().

bq.  Since all DISIs should have their doc() implemented, that shouldn't be a problem.
This should be "Since all DISIs should have their docID() implemented, that shouldn't be a
problem.", then it makes sense to me.

      was (Author: thetaphi):
    bq. I kept nextDoc() as is, i.e., calling doc() instead of docID(), since that's required
for back-compat. Since all DISIs should have their doc() implemented, that shouldn't be a
problem.

But doc() is also deprecated, why should they have implemented it? This makes no sense for
me. Non-deprecated-code should always call non-deprectaed methods, so docID().
  
> Add next() and skipTo() variants to DocIdSetIterator that return the current doc, instead
of boolean
> ----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1614
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1614
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Shai Erera
>             Fix For: 2.9
>
>         Attachments: LUCENE-1614.patch, LUCENE-1614.patch, LUCENE-1614.patch, LUCENE-1614.patch,
LUCENE-1614.patch, LUCENE-1614.patch, LUCENE-1614.patch, LUCENE-1614.patch, LUCENE-1614.patch,
LUCENE-1614.patch, LUCENE-1614.patch, LUCENE-1614.patch, LUCENE-1614.patch
>
>
> See http://www.nabble.com/Another-possible-optimization---now-in-DocIdSetIterator-p23223319.html
for the full discussion. The basic idea is to add variants to those two methods that return
the current doc they are at, to save successive calls to doc(). If there are no more docs,
return -1. A summary of what was discussed so far:
> # Deprecate those two methods.
> # Add nextDoc() and skipToDoc(int) that return doc, with default impl in DISI (calls
next() and skipTo() respectively, and will be changed to abstract in 3.0).
> #* I actually would like to propose an alternative to the names: advance() and advance(int)
- the first advances by one, the second advances to target.
> # Wherever these are used, do something like '(doc = advance()) >= 0' instead of comparing
to -1 for improved performance.
> I will post a patch shortly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message