lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] Commented: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory
Date Sun, 31 May 2009 10:38:07 GMT


Uwe Schindler commented on LUCENE-1658:

Caching of FSDirs was completely removed

I think this must wait until 3.0, ie when we remove all getDirectory

I am currently playing with this. For the end-user it is not really needed, that directories
are cached. Even if he gets a directory that it is cached, he can see it as a alone one. he
can close it (because of refcounting and so on) and do everything, he can do with a single
directory, too.

So whay is it not backwards compatible, wen we remove caching. All tests pass here!

More, the mixing of cached and uncached dirs bring more problems (I am currently investigating).

I will supply a new patch shortly, with all other bugs fixed (there were more, e.g. with some
tests in _TestHelper and so on). The move from FSDir to SimpleFSDir is more complicated than
it seems. In my opinion, it would be a question, if *this* move should wait until 3.0.

> Absorb NIOFSDirectory into FSDirectory
> --------------------------------------
>                 Key: LUCENE-1658
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Michael McCandless
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 2.9
>         Attachments: LUCENE-1658-take2.patch, LUCENE-1658-take2.patch, LUCENE-1658.patch,
LUCENE-1658.patch, LUCENE-1658.patch
> I think whether one uses* vs java.nio.* or eventually
> java.nio2.*, or some other means, is an under-the-hood implementation
> detail of FSDirectory and doesn't merit a whole separate class.
> I think FSDirectory should be the core class one uses when one's index
> is in the filesystem.
> So, I'd like to deprecate NIOFSDirectory, absorbing it into
> FSDirectory, and add a setting "useNIO" to FSDirectory.  It should
> default to "true" for non-Windows OSs, because it gives far better
> concurrent performance on all platforms but Windows (due to known Sun
> JRE issue

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message