lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory
Date Sun, 31 May 2009 14:17:07 GMT


Michael McCandless commented on LUCENE-1658:

I am not so happy , but I work on it.

I am looking now since 5 hourcs and cannot find the error, the code consists of a lot of printlns
and so on. 

We can tag-team if you want :)  Let me know if you want me to take over...

bq. This failure depends on the random seed in testFSDirectoryReopen2() and is reproducible
also with the current version of FSDirectory. It seems that 1453 is not completely fixed.

Yikes -- you mean there's a pre-existing issue with the fix in LUCENE-1453, before this issue
was committed?  I agree that code is very spooky, and I'll be very happy once we remove (in
3.0) the cache/refCounting done by FSDir.getDirectory....

bq.  If we do not want to do this, I suggest to deprecate all these methods and tell the user
to open the directory themselfes and pass Directory instances to Writer/Reader

I like this (deprecating the open methods that take File/String) best!

bq. I have a lot of other fixes for the failing tests on some platforms, I will post a revised
patch some time with getDirectory deprecated and open() again.

OK thanks.

> Absorb NIOFSDirectory into FSDirectory
> --------------------------------------
>                 Key: LUCENE-1658
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Michael McCandless
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 2.9
>         Attachments: LUCENE-1658-take2.patch, LUCENE-1658-take2.patch, LUCENE-1658.patch,
LUCENE-1658.patch, LUCENE-1658.patch
> I think whether one uses* vs java.nio.* or eventually
> java.nio2.*, or some other means, is an under-the-hood implementation
> detail of FSDirectory and doesn't merit a whole separate class.
> I think FSDirectory should be the core class one uses when one's index
> is in the filesystem.
> So, I'd like to deprecate NIOFSDirectory, absorbing it into
> FSDirectory, and add a setting "useNIO" to FSDirectory.  It should
> default to "true" for non-Windows OSs, because it gives far better
> concurrent performance on all platforms but Windows (due to known Sun
> JRE issue

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message