lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Created: (LUCENE-1653) Change DateTools to not create a Calendar in every call to dateToString or timeToString
Date Thu, 21 May 2009 20:55:45 GMT
Change DateTools to not create a Calendar in every call to dateToString or timeToString
---------------------------------------------------------------------------------------

                 Key: LUCENE-1653
                 URL: https://issues.apache.org/jira/browse/LUCENE-1653
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Other
            Reporter: Shai Erera
            Priority: Minor
             Fix For: 2.9


DateTools creates a Calendar instance on every call to dateToString and timeToString. Specifically:

# timeToString calls Calendar.getInstance on every call.
# dateToString calls timeToString(date.getTime()), which then instantiates a new Date(). I
think we should change the order of the calls, or not have each call the other.
# round(), which is called from timeToString (after creating a Calendar instance) creates
another (!) Calendar instance ...

Seems that if we synchronize the methods and create the Calendar instance once (static), it
should solve it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message