lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn van Groningen (JIRA)" <j...@apache.org>
Subject [jira] Created: (LUCENE-1661) Change visibility of getComparator method in SortField from protected to public
Date Tue, 26 May 2009 19:46:45 GMT
Change visibility of getComparator method in SortField from protected to public
-------------------------------------------------------------------------------

                 Key: LUCENE-1661
                 URL: https://issues.apache.org/jira/browse/LUCENE-1661
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Search
    Affects Versions: 2.9
            Reporter: Martijn van Groningen
            Priority: Minor
         Attachments: SortField.patch

Hi,

Currently I'm using SortField for the creation of FieldComparators, but I ran into an issue.
I cannot invoke SortField.getComparator(...) directly from my code, which forces me to use
a  workaround. (subclass SortField and override the getComparator method with visiblity public)
I'm proposing to make this method public. Currently I do not see any problems changing the
visibility to public, I do not know if there are any (and the reason why this method is currently
protected)
I think that this is a cleaner solution then the workaround I used and also other developers
can benefit from it. I will also attach a patch to this issue based on the code in the trunk
(26th of May). place). 
Please let me know your thoughts about this.

Cheers,

Martijn

 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message