lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Earwin Burrfoot <ear...@gmail.com>
Subject SegmentReader instantiation
Date Thu, 21 May 2009 14:17:36 GMT
Right now a set of system properties and Class.newInstance() is used
to create SegmentReader.

I've tracked down this code's origins to:
r150531 | cutting | 2004-09-22 22:32:27 +0400 (ср, 22 сен 2004) | 2 lines
Add GCJ native code for SegmentTermDocs.read(int[],int[]) to
accellerate TermScorer.  TermScorer and BooleanScorer are now usually
a bit faster under GCJ than under Sun's JVM.

Anybody uses this? Let's just go ahead, scrap it, and construct
classes using er.. constructors? :)
No adequate docs for this feature exist, except a very brief mention
in CHANGES.txt.
Even more - when ReadonlySegmentReader was introduced, instantiation
code was blindly copypasted, but no matching GCJReadonlySegmentReader
was created and corresponding Makefile wasn't altered, thus
GCJ-optimized Lucene is currently broken on trunk.
Removal of this feature also won't break any theoretical old apps that
magically happen to use it, because we'll simply ignore the property
with zero change in runtime behaviour.

-- 
Kirill Zakharenko/Кирилл Захаренко (earwin@gmail.com)
Home / Mobile: +7 (495) 683-567-4 / +7 (903) 5-888-423
ICQ: 104465785

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message