lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Earwin Burrfoot <ear...@gmail.com>
Subject Re: Re(opening) (Multi)SegmentReaders
Date Tue, 19 May 2009 19:23:06 GMT
Okay, I've got some more time on my hands.
While fixing the tests, I found a reopen() bug on trunk, which was
previously hidden from tests by SR-as-toplevel-reader optimization.
(LUCENE-1645)
Can post the first experimental patch tomorrow, with this test failing.

On Mon, May 18, 2009 at 16:06, Michael McCandless
<lucene@mikemccandless.com> wrote:
> On Mon, May 18, 2009 at 7:56 AM, Earwin Burrfoot <earwin@gmail.com> wrote:
>> Will post one soon.
>>
>> Had to slightly modify a whole bunch of tests relying on
>> IndexReader.open(dir) returning SegmentReader instance for
>> single-segment indexes.
>> Currently struggling with Clone/CloneNorms/Reopen tests that actually
>> verify old behaviour.
>>
>> The fun part is - SR no longer has to pose as toplevel
>> directory-owning reader, so most of stuff moved from DIR to MSR and
>> now DIR is almost empty, save for static factory methods and a pair of
>> flags.
>> I'm going to remove DIR completely and make MSR/SR inherit directly from IR.
>
> Sounds good!  Nice simplifications...
>
>> All affected classes/methods are package-private, so I bet that
>> doesn't hamper backwards compatibility?
>
> Run ant test-tag to see if the machine agrees with you?
>
> Likely tests will fail, eg at least those verifying old behavior, but
> if it's because these tests were relying on package-private APIs or
> old behavior, you should fix the tests (on the back-compat branch) and
> include that in your patch.
>
> Yonik is there anything in Solr that might not like this change?
>
> Mike
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>



-- 
Kirill Zakharenko/Кирилл Захаренко (earwin@gmail.com)
Home / Mobile: +7 (495) 683-567-4 / +7 (903) 5-888-423
ICQ: 104465785

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message