lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1614) Add next() and skipTo() variants to DocIdSetIterator that return the current doc, instead of boolean
Date Fri, 29 May 2009 19:52:45 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714567#action_12714567
] 

Shai Erera commented on LUCENE-1614:
------------------------------------

bq. Under what cases are NPE & AIOOBE thrown by ReqExclScorer?

Previously, ReqExclScorer had this code:

{code}
public int doc() {
  return reqScorer.doc(); // reqScorer may be null when next() or skipTo() already return
false
}
{code}

The current patch already fixes it to not rely on reqScorer to be or not be null (we've also
discussed this issue somewhere up this thread).

bq. I don't think we need to document that you shouldn't throw RuntimeExceptions

Yeah ... I guess you're right. When I read the documentation it does sound kind of silly (as
if we're begging "please don't throw RuntimeException"). I'll remove that. I just wanted to
encourage implementers to not rely on an object which may or may not be null (or index going
out of range).

bq. Well the javadoc clearly states the requirement ("next must be called")

You're right Mike, I didn't read the javadocs (shame on me :) ). I'll fix the code then.

> Add next() and skipTo() variants to DocIdSetIterator that return the current doc, instead
of boolean
> ----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1614
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1614
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Shai Erera
>             Fix For: 2.9
>
>         Attachments: LUCENE-1614.patch, LUCENE-1614.patch, LUCENE-1614.patch, LUCENE-1614.patch,
LUCENE-1614.patch, LUCENE-1614.patch, LUCENE-1614.patch
>
>
> See http://www.nabble.com/Another-possible-optimization---now-in-DocIdSetIterator-p23223319.html
for the full discussion. The basic idea is to add variants to those two methods that return
the current doc they are at, to save successive calls to doc(). If there are no more docs,
return -1. A summary of what was discussed so far:
> # Deprecate those two methods.
> # Add nextDoc() and skipToDoc(int) that return doc, with default impl in DISI (calls
next() and skipTo() respectively, and will be changed to abstract in 3.0).
> #* I actually would like to propose an alternative to the names: advance() and advance(int)
- the first advances by one, the second advances to target.
> # Wherever these are used, do something like '(doc = advance()) >= 0' instead of comparing
to -1 for improved performance.
> I will post a patch shortly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message