lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Earwin Burrfoot (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory
Date Tue, 26 May 2009 09:59:45 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712930#action_12712930
] 

Earwin Burrfoot commented on LUCENE-1658:
-----------------------------------------

Yay for base class + three concrete impls (haven't yet looked at the patch).

bq. I was tempted to choose MMapDir on 64 bit Windows JRE, but it makes me nervous...
Not completely sure why, but MMap failed for me on Win32 some time ago

bq. Is this something you could share? Sounds useful! Likewise if you extend MMapDir for writing...
It's a one-liner. I can make a patch, but while it works better than vanilla MMapD, I'm not
yet sure it's the best approach. As for writing - okay, I'll tell you if it turns out to be
anything good.

bq. Does anyone have a strong sense of when MMapDir is / is not an appropriate choice?
There are a lot of variables. Just as you said, on 32bit systems you have to take care of
address space. So, nice for small indexes, bad for big ones. But, mmap in Java cannot be explicitly
closed, it is closed in finalizer, so even for a small index if you update really often, you
can hit an OOM even though you have enough memory. MMapD failed for me on windows. But it
is fast. It is absolutely, totally, uber-indespensible, if you have a 64bit system, fat index,
memory to spare and require lots of fast searches.

So, you can probably enable it for non-Win 64bit?

> Absorb NIOFSDirectory into FSDirectory
> --------------------------------------
>
>                 Key: LUCENE-1658
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1658
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1658.patch, LUCENE-1658.patch
>
>
> I think whether one uses java.io.* vs java.nio.* or eventually
> java.nio2.*, or some other means, is an under-the-hood implementation
> detail of FSDirectory and doesn't merit a whole separate class.
> I think FSDirectory should be the core class one uses when one's index
> is in the filesystem.
> So, I'd like to deprecate NIOFSDirectory, absorbing it into
> FSDirectory, and add a setting "useNIO" to FSDirectory.  It should
> default to "true" for non-Windows OSs, because it gives far better
> concurrent performance on all platforms but Windows (due to known Sun
> JRE issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6265734).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message