lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wouter Heijke (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1636) TokenFilters with a null value in the constructor fail
Date Fri, 22 May 2009 02:46:45 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711933#action_12711933
] 

Wouter Heijke commented on LUCENE-1636:
---------------------------------------

I'm on holiday now, but as far as I recollect (as I was not the author of the code) it was
done on some filters that would be used in another situation (similar to a filter) to use
the filter's functionality. Also it was used with filters that could not be extended, so a
new filter was created, also here the orignal filter's public methods would be called.

In a way it doesn't matter, it could be done with the api without any problems with the latest
few releases that i know of.

A more elegant way if one would like to introduce this new behaviour is to at least log some
kind of error message in the 2.9 release so users would be alarmed that they use the Lucene
api in a way that is not supported anymore.


> TokenFilters with a null value in the constructor fail
> ------------------------------------------------------
>
>                 Key: LUCENE-1636
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1636
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.9
>            Reporter: Wouter Heijke
>            Assignee: Michael McCandless
>             Fix For: 2.9
>
>         Attachments: LUCENE-1636.patch
>
>
> While migrating from 2.4.x to 2.9-dev I found a lot of failing unittests.
> One problem is with TokenFilters that do a super(null) in the constructor.
> I fixed it by changing the constructor to super(new EmptyTokenStream())
> This will cause problems and frustration to others while migrating to 2.9.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message