lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] Commented: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory
Date Sun, 31 May 2009 00:00:07 GMT


Uwe Schindler commented on LUCENE-1658:

One comment:
The part with the reflection and the ctor may be non-backwards compatible, because if somebody
overwrites the old FSDir and does not provide the wanted ctor (only the default one), it would
fail. The default ctor would not even work, as the init() private internal method (used by
the old getDirectory()) is no longer available.
But this is the same like in the discussion about backwards compatibility. In my opinion,
for 2.9, we should make FSDir abstract, too. It is sooooooo seldom, that somebody may create
a file based dir impl (nio.2 or what else? Or Earwins MemoryCopiedDir). But if somebody does
this, he knows what he does and can fix the compilation errors easily!

> Absorb NIOFSDirectory into FSDirectory
> --------------------------------------
>                 Key: LUCENE-1658
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Michael McCandless
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 2.9
>         Attachments: LUCENE-1658-take2.patch, LUCENE-1658.patch, LUCENE-1658.patch, LUCENE-1658.patch
> I think whether one uses* vs java.nio.* or eventually
> java.nio2.*, or some other means, is an under-the-hood implementation
> detail of FSDirectory and doesn't merit a whole separate class.
> I think FSDirectory should be the core class one uses when one's index
> is in the filesystem.
> So, I'd like to deprecate NIOFSDirectory, absorbing it into
> FSDirectory, and add a setting "useNIO" to FSDirectory.  It should
> default to "true" for non-Windows OSs, because it gives far better
> concurrent performance on all platforms but Windows (due to known Sun
> JRE issue

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message