lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (LUCENE-1636) TokenFilters with a null value in the constructor fail
Date Fri, 22 May 2009 01:53:45 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711920#action_12711920
] 

Uwe Schindler edited comment on LUCENE-1636 at 5/21/09 6:53 PM:
----------------------------------------------------------------

Mike:
Would this affect backwards compatibility? If we make it final and nobody changes the stream,
everything is ok. Is this also the case, when using lucene.jar as a dropin-replacement without
recompilation? Will changing a final variable from code, compiled before finalization, be
detected by the JVM? Is the compiled code with final still binary compatible to code compiled
againt non-final members?
I think, we should try this out before committing!

      was (Author: thetaphi):
    Mike:
Would this affect backwards compatibility? If we make it final and nobody changes the stream,
everything is ok. Is this also the case, when using plugin-replacement without recompilation?
Will changing a final variable from code, compiled before finalization, be detected by the
JVM? Is the compiled code with final still binary compatible to code compiled againt non-final
members?
I think, we should try this out before committing!
  
> TokenFilters with a null value in the constructor fail
> ------------------------------------------------------
>
>                 Key: LUCENE-1636
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1636
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.9
>            Reporter: Wouter Heijke
>            Assignee: Michael McCandless
>             Fix For: 2.9
>
>         Attachments: LUCENE-1636.patch
>
>
> While migrating from 2.4.x to 2.9-dev I found a lot of failing unittests.
> One problem is with TokenFilters that do a super(null) in the constructor.
> I fixed it by changing the constructor to super(new EmptyTokenStream())
> This will cause problems and frustration to others while migrating to 2.9.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message