lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-1650) Small fix in CustomScoreQuery JavaDoc
Date Thu, 21 May 2009 01:58:45 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Simon Willnauer updated LUCENE-1650:
------------------------------------

    Attachment: customScoreQuery_CodeChange+JavaDoc.patch
                customScoreQuery_JavaDoc.patch

> Small fix in CustomScoreQuery JavaDoc
> -------------------------------------
>
>                 Key: LUCENE-1650
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1650
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Javadocs
>    Affects Versions: 2.9, 3.0
>            Reporter: Simon Willnauer
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: customScoreQuery_CodeChange+JavaDoc.patch, customScoreQuery_JavaDoc.patch
>
>
> I have fixed the javadoc for  "Modified Score" formular in CustomScoreQuery. - Patch
attached: customScoreQuery_JavaDoc.patch 
> I'm quite curious why the method:
>  public float customScore(int doc, float subQueryScore, float valSrcScores[]) 
> calls public float customScore(int doc, float subQueryScore, float valSrcScore])  only
in 2 of the 3 cases which makes the choice to override either one of the customScore methods
dependent on the number of ValueSourceQuery passed to the constructor. I figure it would be
more consistent if it would call the latter in all 3 cases.
> I also attached a patch which proposes a fix for that issue. The patch does also include
the JavaDoc issue mentioned above.
> - customScoreQuery_CodeChange+JavaDoc.patch

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message