lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory
Date Sun, 31 May 2009 10:30:07 GMT


Michael McCandless commented on LUCENE-1658:

Ugh, I'm sorry... I had run the tests only on OS X, Java 1.5, which is
not 64 bit by default (must specify -d64) -- I should have tested the
different OS's and JREs before committing.

Thanks for jumping on this, Uwe and Earwin!

bq. was removed, the logic was included into FSDir.getDirectory and this un-deprectated:
If the system property is missing, the same like in Mikes open() happens: choosing the best
impl for platform

But: the removal of the cache is not back-compatible?  (I'm not sure
how/whether anyone relies on that behavior).  And, we are wanting to
move away from that global System property in choosing the class for
your FSDir.  This is why I switched to open instead of back to

bq. Caching of FSDirs was completely removed

I think this must wait until 3.0, ie when we remove all getDirectory

bq. FSDir.IndexInput/Output (deprected) was removed (suplicate code) and simply replaced by
(deprecated) subclasses of SimpleFSDir ones). This is OK for backwards compatibility.


> Absorb NIOFSDirectory into FSDirectory
> --------------------------------------
>                 Key: LUCENE-1658
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Michael McCandless
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 2.9
>         Attachments: LUCENE-1658-take2.patch, LUCENE-1658-take2.patch, LUCENE-1658.patch,
LUCENE-1658.patch, LUCENE-1658.patch
> I think whether one uses* vs java.nio.* or eventually
> java.nio2.*, or some other means, is an under-the-hood implementation
> detail of FSDirectory and doesn't merit a whole separate class.
> I think FSDirectory should be the core class one uses when one's index
> is in the filesystem.
> So, I'd like to deprecate NIOFSDirectory, absorbing it into
> FSDirectory, and add a setting "useNIO" to FSDirectory.  It should
> default to "true" for non-Windows OSs, because it gives far better
> concurrent performance on all platforms but Windows (due to known Sun
> JRE issue

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message