lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1658) Absorb NIOFSDirectory into FSDirectory
Date Sun, 31 May 2009 10:30:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714848#action_12714848
] 

Michael McCandless commented on LUCENE-1658:
--------------------------------------------


Ugh, I'm sorry... I had run the tests only on OS X, Java 1.5, which is
not 64 bit by default (must specify -d64) -- I should have tested the
different OS's and JREs before committing.

Thanks for jumping on this, Uwe and Earwin!

bq. FSDir.open() was removed, the logic was included into FSDir.getDirectory and this un-deprectated:
If the system property is missing, the same like in Mikes open() happens: choosing the best
impl for platform

But: the removal of the cache is not back-compatible?  (I'm not sure
how/whether anyone relies on that behavior).  And, we are wanting to
move away from that global System property in choosing the class for
your FSDir.  This is why I switched to open instead of back to
getDirectory.

bq. Caching of FSDirs was completely removed

I think this must wait until 3.0, ie when we remove all getDirectory
methods.

bq. FSDir.IndexInput/Output (deprected) was removed (suplicate code) and simply replaced by
(deprecated) subclasses of SimpleFSDir ones). This is OK for backwards compatibility.

Excellent!

> Absorb NIOFSDirectory into FSDirectory
> --------------------------------------
>
>                 Key: LUCENE-1658
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1658
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Store
>            Reporter: Michael McCandless
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1658-take2.patch, LUCENE-1658-take2.patch, LUCENE-1658.patch,
LUCENE-1658.patch, LUCENE-1658.patch
>
>
> I think whether one uses java.io.* vs java.nio.* or eventually
> java.nio2.*, or some other means, is an under-the-hood implementation
> detail of FSDirectory and doesn't merit a whole separate class.
> I think FSDirectory should be the core class one uses when one's index
> is in the filesystem.
> So, I'd like to deprecate NIOFSDirectory, absorbing it into
> FSDirectory, and add a setting "useNIO" to FSDirectory.  It should
> default to "true" for non-Windows OSs, because it gives far better
> concurrent performance on all platforms but Windows (due to known Sun
> JRE issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6265734).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message