Return-Path: 
 <java-dev-return-32038-apmail-lucene-java-dev-archive=lucene.apache.org@lucene.apache.org>
Delivered-To: apmail-lucene-java-dev-archive@www.apache.org
Received: (qmail 33614 invoked from network); 11 Apr 2009 10:21:55 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 11 Apr 2009 10:21:55 -0000
Received: (qmail 69933 invoked by uid 500); 11 Apr 2009 10:21:54 -0000
Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org
Received: (qmail 69828 invoked by uid 500); 11 Apr 2009 10:21:54 -0000
Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:java-dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:java-dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:java-dev@lucene.apache.org>
List-Id: <java-dev.lucene.apache.org>
Reply-To: java-dev@lucene.apache.org
Delivered-To: mailing list java-dev@lucene.apache.org
Received: (qmail 69820 invoked by uid 99); 11 Apr 2009 10:21:54 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Apr 2009 10:21:54 +0000
X-ASF-Spam-Status: No, hits=2.2 required=10.0
	tests=HTML_MESSAGE,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of serera@gmail.com designates
 209.85.219.179 as permitted sender)
Received: from [209.85.219.179] (HELO mail-ew0-f179.google.com)
 (209.85.219.179)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Apr 2009 10:21:47 +0000
Received: by ewy27 with SMTP id 27so1553550ewy.5
        for <java-dev@lucene.apache.org>;
 Sat, 11 Apr 2009 03:21:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:in-reply-to:references
         :date:message-id:subject:from:to:content-type;
        bh=n+DVYnnFU7JNKI7VV0WzJ/cp02kcnuChZX4WHMJwWqk=;
        b=xMBe3qeaTtXyQG+AuqtoBGG37z8KTWBrPvePQgKFbrZcYAN0gHLGRGJFfZTJo5pIm7
         PkV+CQm77tQvArGCnf342uvzST3EE0RKht03E09TFFOcIGXwth0uDuI/MQt8vaCwoNfJ
         j/OFWF5ZBH4mPMukvS0t8ykI/aarOAsANixZ4=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=up9uayDOl7vojrIo2DEWIQHFRUZl5gO72lXFfpX5xUDF89rl3hdFwWjq/UWrTvOniG
         SLpyvQOlKDzdXd1WAA0QoKT7hIB/CWnBdzoDUt2kVQ87o25kRGWeSX5g+rf/UzQWjCCe
         +vuNF8U+FRI+6WcI3isbLLvSJk8T96yIiRO40=
MIME-Version: 1.0
Received: by 10.216.11.72 with SMTP id 50mr1081398wew.64.1239445286441; Sat,
	11 Apr 2009 03:21:26 -0700 (PDT)
In-Reply-To: <9ac0c6aa0904110259n63f74dd4qc41799c284146bf@mail.gmail.com>
References: <786fde50904102204t20bec3el2279f515f4cda833@mail.gmail.com>
	 <786fde50904102309m4825e6f3v66a40e5ad348e007@mail.gmail.com>
	 <9ac0c6aa0904110259n63f74dd4qc41799c284146bf@mail.gmail.com>
Date: Sat, 11 Apr 2009 13:21:26 +0300
Message-ID: <786fde50904110321s570498d1y4cb805e342e9838@mail.gmail.com>
Subject: Re: WriteLineDocTask does not release resources
From: Shai Erera <serera@gmail.com>
To: java-dev@lucene.apache.org
Content-Type: multipart/alternative; boundary=001485f1ea660454bb046744d8a0
X-Virus-Checked: Checked by ClamAV on apache.org

--001485f1ea660454bb046744d8a0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

That explains everything. I started to work on 1591 before you committed
1516, and was looking for something like this close() method the entire
morning ... :)

I agree with everything you say. This PerfTask.close() also allows one to
write a Close<task name> task, in case calling that close() is necessary in
the middle of the execution.

Thanks !

On Sat, Apr 11, 2009 at 12:59 PM, Michael McCandless <
lucene@mikemccandless.com> wrote:

>
> For "larger" resources (my IndexReader, IndexWriter) I do think we
> should make it explicit when they get closed?

--001485f1ea660454bb046744d8a0
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">That explains everything. I started to work on 1591 before=
 you committed 1516, and was looking for something like this close() method=
 the entire morning ... :)<br><br>I agree with everything you say. This Per=
fTask.close() also allows one to write a Close&lt;task name&gt; task, in ca=
se calling that close() is necessary in the middle of the execution.<br>
<br>Thanks !<br><br><div class=3D"gmail_quote">On Sat, Apr 11, 2009 at 12:5=
9 PM, Michael McCandless <span dir=3D"ltr">&lt;<a href=3D"mailto:lucene@mik=
emccandless.com">lucene@mikemccandless.com</a>&gt;</span> wrote:<br><blockq=
uote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, 204, 20=
4); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
For &quot;larger&quot; resources (my IndexReader, IndexWriter) I do think w=
e<br>
should make it explicit when they get closed?</blockquote></div><br></div>

--001485f1ea660454bb046744d8a0--