Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 46153 invoked from network); 28 Apr 2009 08:35:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 28 Apr 2009 08:35:56 -0000 Received: (qmail 40914 invoked by uid 500); 28 Apr 2009 08:35:53 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 40783 invoked by uid 500); 28 Apr 2009 08:35:53 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 40680 invoked by uid 99); 28 Apr 2009 08:35:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Apr 2009 08:35:52 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Apr 2009 08:35:52 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 601A3234C4B6 for ; Tue, 28 Apr 2009 01:35:31 -0700 (PDT) Message-ID: <584909086.1240907731392.JavaMail.jira@brutus> Date: Tue, 28 Apr 2009 01:35:31 -0700 (PDT) From: "Michael McCandless (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-1619) TermAttribute.termLength() optimization In-Reply-To: <2086881420.1240863810470.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703537#action_12703537 ] Michael McCandless commented on LUCENE-1619: -------------------------------------------- Indeed it seems unnecessary -- I'll commit. Thanks Eks! > TermAttribute.termLength() optimization > --------------------------------------- > > Key: LUCENE-1619 > URL: https://issues.apache.org/jira/browse/LUCENE-1619 > Project: Lucene - Java > Issue Type: Improvement > Components: Analysis > Reporter: Eks Dev > Assignee: Michael McCandless > Priority: Trivial > Attachments: LUCENE-1619.patch > > > public int termLength() { > initTermBuffer(); // This patch removes this method call > return termLength; > } > I see no reason to initTermBuffer() in termLength()... all tests pass, but I could be wrong? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org