Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 76164 invoked from network); 24 Apr 2009 21:45:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 24 Apr 2009 21:45:12 -0000 Received: (qmail 73175 invoked by uid 500); 24 Apr 2009 21:45:11 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 73090 invoked by uid 500); 24 Apr 2009 21:45:11 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 73082 invoked by uid 99); 24 Apr 2009 21:45:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Apr 2009 21:45:10 +0000 X-ASF-Spam-Status: No, hits=-4.0 required=10.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [128.230.18.71] (HELO mx3.syr.edu) (128.230.18.71) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Apr 2009 21:45:02 +0000 Received: from suex07-hub-02.ad.syr.edu (suex07-hub-02.ad.syr.edu [128.230.108.196]) by mx3.syr.edu (8.14.3/8.14.3) with ESMTP id n3OLifFj022215 for ; Fri, 24 Apr 2009 17:44:41 -0400 Received: from suex07-mbx-03.ad.syr.edu ([128.230.108.133]) by suex07-hub-02.ad.syr.edu ([fe80::813b:49a2:a4d5:6367%10]) with mapi; Fri, 24 Apr 2009 17:44:41 -0400 From: Steven A Rowe To: "java-dev@lucene.apache.org" Date: Fri, 24 Apr 2009 17:44:38 -0400 Subject: RE: CHANGES.txt Thread-Topic: CHANGES.txt Thread-Index: AcnFHaq+Jm7olEUDTkW9ncB08J43DwABPLgA Message-ID: <2D127F11DC79714E9B6A43AC9458147F13FCA447@suex07-mbx-03.ad.syr.edu> References: <2D127F11DC79714E9B6A43AC9458147F13FCA3E2@suex07-mbx-03.ad.syr.edu> <9ac0c6aa0904241345g6b033008n7ae8118b048480da@mail.gmail.com> In-Reply-To: <9ac0c6aa0904241345g6b033008n7ae8118b048480da@mail.gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=1.12.7400:2.4.4,1.2.40,4.0.166 definitions=2009-04-24_10:2009-04-23,2009-04-24,2009-04-24 signatures=0 X-Proofpoint-Spam-Reason: safe X-Virus-Checked: Checked by ClamAV on apache.org Hi Mike, On 4/24/2009 at 4:45 PM, Michael McCandless wrote: > On Fri, Apr 17, 2009 at 1:46 PM, Steven A Rowe wrote: > > - Five issues (LUCENE-1186, 1452, 1453, 1465 and 1544) are mentioned > > in both the 2.4.1 section and in the Trunk section. =A0AFAICT, it has > > not been standard practice to mention bug fixes on a major or minor > > release (which Trunk will become) if they are mentioned on a prior > > patch release. >=20 > Hmm -- I thought it'd be good to be clear on which bugs were fixed, > where, even if it causes some redundancy? Right: SUM(+1 clarity, -0.5 redundancy) =3D +0.5 :) So the policy you're suggesting is: "When backporting bug fixes from trunk = to a patch version, make note of the change in both the trunk and patch ver= sion sections of CHANGES.txt", right? Makes sense (though as I noted, this policy has never before been used), bu= t why then did you include only 5 out of the 15 bug fixes listed under 2.4.= 1 in the Trunk section? > > - The Trunk section sports use of a new feature:

 sections,
> > for the two mentions of LUCENE-1575. =A0This looks fine in the text
> > rendering, but looks crappy in the HTML version, since
> > changes2html.pl escapes HTML metacharacters to appear as-is in
> > the HTML rendering, but the newlines in the code are converted to
> > a single space. =A0I think this should be fixed by modifying
> > changes2html.pl to convert  and  into (unescaped)
> >  and , respectively, since just passing
> > through  and , without , while changing the
> > font to monospaced (nice), still collapses whitespace (not nice).
> >=A0(There is a related question: should all HTML tags in CHANGES.txt
> > be passed through without being escaped? =A0I don't think so;
> > better to handle them on a case-by-case basis, as the need
> > arises.)
>=20
> Can you make a patch for ...?  (I like that
> approach).  I agree let's not make it generic to all HTML tags for
> now...

Done: https://issues.apache.org/jira/browse/LUCENE-1610

Steve


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org