lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1604) Stop creating huge arrays to represent the absense of field norms
Date Thu, 16 Apr 2009 14:38:15 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699720#action_12699720
] 

Michael McCandless commented on LUCENE-1604:
--------------------------------------------

bq. Setting disableFakeNorms transitively isn't really needed because MultiSegmentReader doesn't
make any calls to the subreaders that would cause it to create it's own fake norms

But since we score per-segment, TermScorer would ask each SegmentReader (in the MultiSegmentReader)
for its norms?  So I think the sub readers need to know the setting.

bq. Any thoughts on whether we need this or not?

I think we do need each class implementing clone() and reopen() to properly carryover this
setting.


> Stop creating huge arrays to represent the absense of field norms
> -----------------------------------------------------------------
>
>                 Key: LUCENE-1604
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1604
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.9
>            Reporter: Shon Vella
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1604.patch, LUCENE-1604.patch
>
>
> Creating and keeping around huge arrays that hold a constant value is very inefficient
both from a heap usage standpoint and from a localility of reference standpoint. It would
be much more efficient to use null to represent a missing norms table.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message