lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1604) Stop creating huge arrays to represent the absense of field norms
Date Mon, 27 Apr 2009 12:39:30 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703103#action_12703103
] 

Michael McCandless commented on LUCENE-1604:
--------------------------------------------

New patch attached:

  * Fixed contrib/instantiated & contrib/misc to pass if I change
    default for disableFakeNorms to true (which we will hardwire in
    3.0)

  * Tweaked javadocs

  * Removed unused imports

  * Added CHANGES.txt entry

I still need to review the rest of the patch...

With this patch, all tests pass with the default set to false
(back-compat).  If I temporarily set it to true, all tests now pass,
except back-compat (which is expected & fine).

I had started down the path of having contrib/instantiated "respect"
the disableFakeNorms setting, but rapidly came to realize how little I
understand contrib/instantiated's code ;) So I fell back to fixing the
unit tests to accept null returns from the normal
IndexReader.norms(...).


> Stop creating huge arrays to represent the absense of field norms
> -----------------------------------------------------------------
>
>                 Key: LUCENE-1604
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1604
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.9
>            Reporter: Shon Vella
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1604.patch, LUCENE-1604.patch, LUCENE-1604.patch
>
>
> Creating and keeping around huge arrays that hold a constant value is very inefficient
both from a heap usage standpoint and from a localility of reference standpoint. It would
be much more efficient to use null to represent a missing norms table.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message