lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1529) back-compat tests ("ant test-tag") should test JAR drop-in-ability
Date Tue, 14 Apr 2009 21:09:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698932#action_12698932
] 

Michael McCandless commented on LUCENE-1529:
--------------------------------------------

bq. If I change the definition to rely only on tag.jar, demo classes and junit jar:

Ooh that's good progress!

Hmm, yes we will now see compilation errors because over time we've made "legal" fixes to
the test source code, corresponding to changes in 2.9.  Eg, since FieldInfo is package private,
we're allowed to rename omitTf to OmitTermFreqAndPositions, and if a test (TestOmitTf) is
using package-private access to access omitTf, it's OK to fix that test to match the new name.

So I think the only way to make "legal" changes to the back-compat tests is to backport [a
subset of, or perhaps compile-time emulation of] the 2.9 changes onto the 2.4 branch src/java/*.
 Or, to fix tests not to rely on package private APIs.  I think that's OK (we make such changes
rarely)?  I'll go and fix the back-compat branch accordingly...

> back-compat tests ("ant test-tag") should test JAR drop-in-ability
> ------------------------------------------------------------------
>
>                 Key: LUCENE-1529
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1529
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Build
>    Affects Versions: 2.9
>            Reporter: Michael McCandless
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: lucene-1529.patch
>
>
> We now test back-compat with "ant test-tag", which is very useful for
> catching breaks in back compat before committing.
> However, that currently checks out "src/test" sources and then
> compiles them against the trunk JAR, and runs the tests.  Whereas our
> back compat policy:
>   http://wiki.apache.org/lucene-java/BackwardsCompatibility
> states that no recompilation is required on upgrading to a new JAR.
> Ie you should be able to drop in the new JAR in place of your old one
> and things should work fine.
> So... we should fix "ant test-tag" to:
>   * Do full checkout of core sources & tests from the back-compat-tag
>   * Compile the JAR from the back-compat sources
>   * Compile the tests against that back-compat JAR
>   * Swap in the trunk JAR
>   * Run the tests

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message