lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1591) Enable bzip compression in benchmark
Date Tue, 14 Apr 2009 19:39:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698893#action_12698893
] 

Shai Erera commented on LUCENE-1591:
------------------------------------

That's strange ... I did the following:
* Checkout trunk to a new project.
* Download latest commons-compress jar Uwe added.
* Applied the patch.
* Ran "ant test".
The result is: BUILD SUCCESSFUL and I see those two test cases pass ... I also ran all tests
from eclipse, they pass too.

testRegularFileWithBZipCompressionEnabled simulates an attempt to read a bz2 file as a regular
file. The very first readLine() should throw a MalformedException or something ... that's
what the test is counting on. It seems that in your case this line succeeds, reading something,
and then fails on String.split(), since probably it didn't read something meaningful. I don't
understand why this would happen though ....
Can you run this test alone, w/o the rest? Perhaps debug-trace it? The test does not delete
the in/output file before and after the test, but relies on FileInputStream(String/File) ctor
which is supposed to re-create the file, even if it exists. Could it be that in your case
it doesn't happen?

I assume the second exception is thrown for the same reason. Following the steps I've done
above to apply the patch, I don't understand why the test fails on your machine ...

> Enable bzip compression in benchmark
> ------------------------------------
>
>                 Key: LUCENE-1591
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1591
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Shai Erera
>             Fix For: 2.9
>
>         Attachments: commons-compress-dev20090413.jar, commons-compress-dev20090413.jar,
LUCENE-1591.patch, LUCENE-1591.patch, LUCENE-1591.patch, LUCENE-1591.patch, LUCENE-1591.patch
>
>
> bzip compression can aid the benchmark package by not requiring extracting bzip files
(such as enwiki) in order to index them. The plan is to add a config parameter bzip.compression=true/false
and in the relevant tasks either decompress the input file or compress the output file using
the bzip streams.
> It will add a dependency on ant.jar which contains two classes similar to GZIPOutputStream
and GZIPInputStream which compress/decompress files using the bzip algorithm.
> bzip is known to be superior in its compression performance to the gzip algorithm (~20%
better compression), although it does the compression/decompression a bit slower.
> I wil post a patch which adds this parameter and implement it in LineDocMaker, EnwikiDocMaker
and WriteLineDoc task. Maybe even add the capability to DocMaker or some of the super classes,
so it can be inherited by all sub-classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message