lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1591) Enable bzip compression in benchmark
Date Sat, 11 Apr 2009 12:00:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698077#action_12698077
] 

Shai Erera commented on LUCENE-1591:
------------------------------------

resetInputs() is called from PerfRunData's ctor (as is setConfig), but also from ResetInputsTask.
Unless it is possible to change the file name in the middle of execution, I see no reason
why not move it to setConfig.

I'll move it to setConfig and also switch to throw IllegalArgEx, insteas of RuntimeEx.

Another change I'd like to do is remove the while(true) in makeDoc. All it does is read 1
line and breaks, unless that line is null in which case it reopens the file and reads a line
again. I think that in that case, which will happen only after all docs were consumed, and
if forever is set to true, we can just call makeDoc again, and avoid the 1-instruction loop
in every makeDoc call.

> Enable bzip compression in benchmark
> ------------------------------------
>
>                 Key: LUCENE-1591
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1591
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Shai Erera
>             Fix For: 2.9
>
>
> bzip compression can aid the benchmark package by not requiring extracting bzip files
(such as enwiki) in order to index them. The plan is to add a config parameter bzip.compression=true/false
and in the relevant tasks either decompress the input file or compress the output file using
the bzip streams.
> It will add a dependency on ant.jar which contains two classes similar to GZIPOutputStream
and GZIPInputStream which compress/decompress files using the bzip algorithm.
> bzip is known to be superior in its compression performance to the gzip algorithm (~20%
better compression), although it does the compression/decompression a bit slower.
> I wil post a patch which adds this parameter and implement it in LineDocMaker, EnwikiDocMaker
and WriteLineDoc task. Maybe even add the capability to DocMaker or some of the super classes,
so it can be inherited by all sub-classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message