lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Earwin Burrfoot (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1616) add one setter for start and end offset to OffsetAttribute
Date Mon, 27 Apr 2009 11:18:30 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703067#action_12703067
] 

Earwin Burrfoot commented on LUCENE-1616:
-----------------------------------------

I have two cases.
In one case I can't access the start offset by the time I set end offset, and therefore have
to introduce a field on the filter for keeping track of it (or use the next case's solution
twice), if separate setters are removed.
In other case I only need to adjust end offset, so I'll have to do attr.setOffset(attr.getStartOffset(),
newEndOffset).
Nothing deadly, but I don't see the point of removing methods that might be useful and don't
interfere with anything.

> add one setter for start and end offset to OffsetAttribute
> ----------------------------------------------------------
>
>                 Key: LUCENE-1616
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1616
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Eks Dev
>            Priority: Trivial
>             Fix For: 2.9
>
>         Attachments: LUCENE-1616.patch
>
>
> add OffsetAttribute. setOffset(startOffset, endOffset);
> trivial change, no JUnit needed
> Changed CharTokenizer to use it

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message