Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 91669 invoked from network); 4 Mar 2009 21:02:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Mar 2009 21:02:28 -0000 Received: (qmail 18168 invoked by uid 500); 4 Mar 2009 21:02:25 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 18114 invoked by uid 500); 4 Mar 2009 21:02:25 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 18105 invoked by uid 99); 4 Mar 2009 21:02:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Mar 2009 13:02:25 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Mar 2009 21:02:18 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 26CEB234C4A7 for ; Wed, 4 Mar 2009 13:01:57 -0800 (PST) Message-ID: <1963207314.1236200517157.JavaMail.jira@brutus> Date: Wed, 4 Mar 2009 13:01:57 -0800 (PST) From: "Michael McCandless (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Assigned: (LUCENE-1552) IndexWriter.addIndexes(IndexReader[] readers) doesn't correctly handle exception success flag. In-Reply-To: <119716383.1236199316129.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless reassigned LUCENE-1552: ------------------------------------------ Assignee: Michael McCandless > IndexWriter.addIndexes(IndexReader[] readers) doesn't correctly handle exception success flag. > ---------------------------------------------------------------------------------------------- > > Key: LUCENE-1552 > URL: https://issues.apache.org/jira/browse/LUCENE-1552 > Project: Lucene - Java > Issue Type: Bug > Affects Versions: 2.4 > Environment: Java > Reporter: Scott Garland > Assignee: Michael McCandless > > After this bit of code in addIndexes(IndexReader[] readers) > try { > flush(true, false, true); > optimize(); // start with zero or 1 seg > success = true; > } finally { > // Take care to release the write lock if we hit an > // exception before starting the transaction > if (!success) > releaseWrite(); > } > The success flag should be reset to "false" because it's used again in another try/catch/finally block. > TestIndexWriter.testAddIndexOnDiskFull() sometimes will hit this bug; but it's infrequent. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org